Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add remote mouse input support. #1870

Merged
merged 4 commits into from
Mar 21, 2024
Merged

HITL - Add remote mouse input support. #1870

merged 4 commits into from
Mar 21, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 19, 2024

Motivation and Context

This changeset adds remote mouse input.

  • Mouse buttons and scrolling are supported.
  • Mouse position is still not supported (mouse ray).

How Has This Been Tested

Tested locally and remotely with Unity client.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from jturner65 and aclegg3 March 19, 2024 16:29
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 19, 2024
aclegg3
aclegg3 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor nit about None checking (multiple occurrences)

habitat-hitl/habitat_hitl/core/remote_client_state.py Outdated Show resolved Hide resolved
@0mdc 0mdc requested a review from jimmytyyang March 21, 2024 17:37
@0mdc 0mdc merged commit 61fa6dd into main Mar 21, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/remote_mouse_input branch March 21, 2024 17:46
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
HITL - Add remote mouse input support. (facebookresearch#1870)
8d6a2ef 
* Rename MouseKeyCode to MouseButton.

* Rename MouseKeyCode to MouseButton.

* Formatting fix.

* Review pass.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL - Add remote mouse input support. (facebookresearch#1870)
1f99f17 
* Rename MouseKeyCode to MouseButton.

* Rename MouseKeyCode to MouseButton.

* Formatting fix.

* Review pass.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
HITL - Add remote mouse input support. (facebookresearch#1870)
898e645 
* Rename MouseKeyCode to MouseButton.

* Rename MouseKeyCode to MouseButton.

* Formatting fix.

* Review pass.
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@0mdc
HITL - Add remote mouse input support. (facebookresearch#1870)
066af94 
* Rename MouseKeyCode to MouseButton.

* Rename MouseKeyCode to MouseButton.

* Formatting fix.

* Review pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 left review comments

@aclegg3 aclegg3 aclegg3 approved these changes

@jimmytyyang jimmytyyang Awaiting requested review from jimmytyyang

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0mdc @jturner65 @aclegg3 @facebook-github-bot